Pc_floppy does not work

odysseus · May 27, 2021, 1:52am

I have a question about pc_floppy on mine it doesn’t work even if I have the floppy without problems :’/

haiku/haiku/blob/master/src/add-ons/kernel/drivers/disk/floppy/pc_floppy/floppy_ctrl.c

/*
 * Copyright 2003-2008, Haiku.
 * Distributed under the terms of the MIT License.
 *
 * Authors:
 *		François Revol <revol@free.fr>
 */


#include <Drivers.h>
#include "floppy.h"


/* VERY verbose... */
//#define DEBUG_LOWLEVEL

#if defined(DEBUG) && DEBUG > 0
#	define PRINT_SR0(x) print_sr0(x)
#else
#	define PRINT_SR0(x) ;

This file has been truncated. show original

extrowerk · May 27, 2021, 4:16am

Please report bugs at dev.haiku-os.org .

odysseus · May 27, 2021, 4:23am

The excuse had forgotten but thanks anyway ^^

extrowerk · May 27, 2021, 5:00am

Your question too. At least i cant seem to find it,

odysseus · May 27, 2021, 5:04am

I just did it on dev

PulkoMandy · May 27, 2021, 7:10am

I think this driver is not finished and difficult to test because of lack of hardware in the hands of the developers.

odysseus · May 27, 2021, 6:42pm

so true … i will learn programming to try to make it work lol it will be difficult ;w;

odysseus · August 2, 2021, 12:23am

https://elixir.bootlin.com/linux/v5.0.21/source/drivers/block
I found this one from linux but I don’t know how to compile
if anyone thinks Freebsd will help ;>

PulkoMandy · August 2, 2021, 7:02am

You can’t use Linux drivers in Haiku because we don’t use the same kernel.

A useful reference for drivers like this is the osdev wiki: Floppy Disk Controller - OSDev Wiki and it links to various other documents and sourcecode of drivers for other systems. You can look what they did, compare with our own driver, and see what we are missing.

Probably you will need to recompile our driver (not the Linux one) with extra tracing to be able to see in the syslog what it’s doing.

odysseus · August 2, 2021, 6:38pm

thanks so it will help a lot, i knew this about the kernel part why i was behind freebsd.

jscipione · August 2, 2021, 8:21pm

If there was one piece of missing functionality that having the BeOS source code could provide, this has got to be it! BeOS had floppy support

PulkoMandy · August 3, 2021, 6:52am

It’s not the most difficult driver to write.

There is some interesting bits in the way BeOS did it, but it shouldn’t be too hard to replicate. Basically they had the floppy copied to a RAM disk, and they would read it on mount, and write it back to disk on unmount only. This makes it much faster to work with floppies and probably made the driver a little simpler since it only needed a “read the whole disk” and a “write the whole disk” operations.

On the other hand, it was not possible to do any kind of low level access to the floppy, which I’d have used a lot at the time to write custom floppy formats for use with old 8bit computers. So it was in fact not suitable for my main use of floppies. Surely we could do better on this part.

TmTFx · August 4, 2021, 5:37am

Well I don’t know how it worked on BeOS, but writing a whole disk should be a long jurney… What about writing only the “diff’ed” sectors?

CodeforEvolution · August 5, 2021, 9:55pm

After looking over the pc_floppy driver’s code, it looks like the reason this driver isn’t functional is that the “Driver Configuration Manager” (a system module that was used for keeping track of internally connected devices on BeOS) is currently unimplemented.

The pc_floppy driver attempts to scan on the ISA bus for floppy drives using the Driver Configuration Manager here:

github.com

haiku/haiku/blob/fe3ac93cdf1d5da37b3edc52a23fcfcd214ce89b/src/add-ons/kernel/drivers/disk/floppy/pc_floppy/floppy.c#L138

    
      
          	}
          	if ((err = get_module(B_CONFIG_MANAGER_FOR_DRIVER_MODULE_NAME, (module_info **)&config_man)) < B_OK) {
          		dprintf(FLO "no config_manager module!\n");
          		put_module(B_ISA_MODULE_NAME);
          		return err;
          	}
          	for (i = 0; i < MAX_FLOPPIES; i++)
          		memset(&(floppies[i]), 0, sizeof(floppy_t));
          	current = 0;
          	register_kernel_daemon(motor_off_daemon, floppies, 5);
          	while (config_man->get_next_device_info(B_ISA_BUS, &cmcookie, &info, sizeof(struct device_info)) == B_OK) {
          		struct device_configuration *conf;
          		struct floppy *master;
          		struct floppy *last = NULL;
          		int flops;
          		if ((info.config_status != B_OK) || 
          				((info.flags & B_DEVICE_INFO_ENABLED) == 0) || 
          				((info.flags & B_DEVICE_INFO_CONFIGURED) == 0) || 
          				(info.devtype.base != PCI_mass_storage) || 
          				(info.devtype.subtype != PCI_floppy) || 
          				(info.devtype.interface != 0) /* XXX: needed ?? */)

This is the code attempting to be called:

github.com

haiku/haiku/blob/fe3ac93cdf1d5da37b3edc52a23fcfcd214ce89b/src/add-ons/kernel/bus_managers/config_manager/config_manager.c#L30

    
      
          #define B_CONFIG_MANAGER_FOR_BUS_MODULE_NAME "bus_managers/config_manager/bus/v1"
          
          
#define FUNCTION(x, y...) dprintf("%s" x, __FUNCTION__, y)
          #define TRACE(x) dprintf x
          
          

          
//	Driver module API
          
          

          
static status_t
          driver_get_next_device_info(bus_type bus, uint64 *cookie, struct device_info *info, uint32 size)
          {
          	FUNCTION("(bus = %d, cookie = %" B_PRId64 ")\n", bus, *cookie);
          	return B_ENTRY_NOT_FOUND;
          }
          
          

          
static status_t
          driver_get_device_info_for(uint64 id, struct device_info *info, uint32 size)
          {
          	FUNCTION("(id = %" B_PRId64 ")\n", id);

I think the solution here would involve wrapping the Driver Configuration Manager around the newer Device Manager framework. However, I don’t think the Device Manager framework has any ISA PNP scanning capabilities… Furthermore, Haiku’s ISA Bus Manager has holes when it comes to DMA transfers. (Though that wouldn’t be a problem for smaller transfers I would think? )

PulkoMandy · August 6, 2021, 6:44am

For floppy disk controllers, there is no plug and play (the floppy controller is just at a fixed address that everyone knows and has not changed since the first model of IBM PC).

Some work was started to handle this type of device with the config_manager (I don’t think it is related to BeOS?). But probably we should use FDT instead to describe that type of hardware.

odysseus · August 17, 2021, 3:14am

from what I understand and almost like NewOS too

odysseus · August 20, 2021, 7:48am

it really can be better this way, I would spend less time and would only access the sector when opening a file for example, I don’t know how they will do more reading the entire disk it should also work fine, I’m just in doubt if it will make it possible to make a bootable floppy disk on account of it’s all in the ram

odysseus · September 4, 2021, 2:45am

I forgot to put my ticket first but it’s here
https://dev.haiku-os.org/ticket/16971
there are some errors, but it’s because it was the first time I made a

bbjimmy · September 4, 2021, 1:25pm

This looks like a duplicate of ticket https://dev.haiku-os.org/ticket/3287

This is over 10 years old, apparently nobody really cares about floppy drives on haiku.

odysseus · September 4, 2021, 6:13pm

yeah, I saw this one but as it’s been over 10 years I ended up making another one