Paladin C++ IDE feedback

Looking into a copy of Paladin in my Developer folder, I have found out that I fixed this problem by commenting out two lines in LibWindow.cpp:

//#ifdef B_SCROLL_VIEW_AWARE
		| B_SCROLL_VIEW_AWARE
//#endif

The ifdef/endif pair checks if there is a B_SCROLL_VIEW_AWARE macro but it’s not able to find it as it is instead defined as:

const uint32 B_SCROLL_VIEW_AWARE = 0x00200000UL; /* 21 */

in headers/os/interface/View.h.
Failing to do so, the flag B_SCROLL_VIEW_AWARE is never added to the BView at compile time.
B_SCROLL_VIEW_AWARE was introduced in Feb 2019 but I can’t tell if it was a macro before, tbh.

I think it’s fairly simple to locally fix it even for non-developers.
Until we know that @adamfowleruk has time to review and approve PRs or he wants to move Paladin to HaikuArchives.

2 Likes