Unable to find ucontext.h

Coldfirex · July 16, 2021, 9:10am

Howdy,
I am trying to compile cppcheck version 2.5 (make cppcheck), and it bombs because it cannot find ucontext.h.
This software is in HaikuDepot (version 1.87), so I checked the package and source for it and it appears to have the same issue when compiling manually. Is the package supposed to contain information on how its compiled?
Any ideas on how I work around this?
I see we have ucontext.h here but I dont see it present on the installed system?

Any help would be appreciated!

extrowerk · July 16, 2021, 9:21am

It should be patched out.

github.com

haikuports/haikuports/blob/14c2cab5428145b93232cb69683a67bbe68a9f06/dev-util/cppcheck/patches/cppcheck-1.87.patchset#L16

    
      
          
          
diff --git a/cli/cppcheckexecutor.cpp b/cli/cppcheckexecutor.cpp
          index 82cc960..ded5fe0 100644
          --- a/cli/cppcheckexecutor.cpp
          +++ b/cli/cppcheckexecutor.cpp
          @@ -52,7 +52,7 @@
           #   include <ucontext.h>
           
           #   undef _XOPEN_SOURCE
          -#elif !defined(__OpenBSD__)
          +#elif !defined(__OpenBSD__) && !defined(__HAIKU__)
           #   include <ucontext.h>
           #endif
           #ifdef __linux__
          diff --git a/cli/threadexecutor.cpp b/cli/threadexecutor.cpp
          index f0534d5..028a28f 100644
          --- a/cli/threadexecutor.cpp
          +++ b/cli/threadexecutor.cpp
          @@ -143,7 +143,7 @@ int ThreadExecutor::handleRead(int rpipe, unsigned int &result)
           
           bool ThreadExecutor::checkLoadAverage(size_t nchildren)

Next time you should read the recipe in the HaikuPorts repo.

Coldfirex · July 16, 2021, 9:25am

Ah, I was expecting it to be in the HPKG file. Thanks for the heads up!

Begasus · July 16, 2021, 9:28am

There is a treasure of patches around at haikuports, if I run into any build problems it’s the first place I look if someone else encountered the same thing
Second place would be the source pages (mostly on github were available)
Third place at repology (some other OS’s can provide solutions also)
Then the web

Coldfirex · July 17, 2021, 12:14am

I was able to get cppcheck 2.5 up and running using 2 of the 3 patches linked. The 3rd one involved compileroptions.cmake which was too different for me to figure out.
With the two trying to build would bomb with " unrecognized command line option ‘-rdynamic’".

I commented it out in the makefil and it compiles and is running basic checks now (woohoo!).

###### Targets

cppcheck: $(LIBOBJ) $(CLIOBJ) $(EXTOBJ)
$(CXX) $(CPPFLAGS) $(CXXFLAGS) -o $@ $^ $(LIBS) $(LDFLAGS) #$(RDYNAMIC)

Question: I’ve read about this error and rdynamic but dont fully grasp it yet. What do we lose by commenting this out? Is there a better way to handle this situation (I assume so).

SamuraiCrow · July 17, 2021, 12:38am

On Haiku, executables are always dynamic, position independent code (PIC). The -rdynamic option probably defines it as a shared object on some systems but I haven’t looked it up.