The Gerrit code review iceberg, episode 5 | Haiku Project

Blog
1

Hello everyone!

We continue our exploration of old change requests on the Gerrit code review tool that have been waiting for several years for someone to pick them up and get them merged. There are currently 316 commits awaiting review in the code review tool. This is quite a bit down from the 350 at the end of last year. It looks like these blog posts are having some positive effect, and also some of the developers could spend a bit more time on Haiku during their winter break?

This is a companion discussion topic for the original entry at https://www.haiku-os.org/blog/pulkomandy/2026-02-03-the_gerrit_pending_review_iceberg_5
7 Likes
2

thats nice to hear

3

Nice article, but I think you forgot a few links “Change ..” in the list?

EDIT: some formatting issue? In the RSS app it shows correctly.

4

I like this blog series as it gives visibility to some open developments :slight_smile:

I might be looking at the Wacom Intuos topic because I own one and already participated to the code.

2 Likes
5

As in the previous episode, it’s just the forum doing weird things. I recommend reading the articles on the website, where it shows just fine.

6

RE: The PACKED change, 1439. I was curious and had a cursory look. The first warning I get building for aarch64 is about BMessage

struct BMessage::message_header {

        uint32          format;
        uint32          what;
        uint32          flags;
        int32           target;
        int32           current_specifier;
        area_id         message_area;
        // reply info
        port_id         reply_port;
        int32           reply_target;
        team_id         reply_team;
        // body info
        uint32          data_size;
        uint32          field_count;
        uint32          hash_table_size;
        int32           hash_table[MESSAGE_BODY_HASH_TABLE_SIZE];
} _PACKED;

port_id, area_id are all typedef int32.

I am wondering why the structure is marked packed at all. Perhaps some of these warnings could be resolved by reviewing the need for _PACKED and dropping it when it doesn’t seem to serve much purpose?

1 Like
7

Yes, packed seems have no effect here and can be safely removed because all fields have 32 bit size.

1 Like