Testing wanted - PS2 active multiplexing (Thinkpad trackpoint mainly)

Hello,

I made a change to fix a bug with the keyboard controller on my machine: https://review.haiku-os.org/c/haiku/+/5388

I would like to check if that does not break the PS2 active multiplexing support. In particular, this can be checked with Thinkpads which have both a trackpoint and a touchpad. But possibly other laptops will be interesting as well.

To test:

  • Install the image from this change
  • Verify that trackpoint and/or touchpad work as wanted
  • Verify that both input devices (touchpad and trackpoint) are visible in Input preferences if they already were without this change
  • grep ps2 /var/log/syslog to see if there is anything strange there

If some people can confirm that this works as intended on thinkpads, I can merge this change. I don’t want to break your pointing devices and I’m not sure what I did will work correctly.

Thanks for your help!

3 Likes

I’ve built the ps2 busmanager with your linked patch and put it into /system/non-packaged/add-ons/kernel/bus_managers. Rebooted and everything seemed fine. Until I touched my touchpad. The PS2 mouse in the Input preferences disappeared with this entry in the syslog:

KERN: ps2: hot removal of input/mouse/ps2/standard_0
KERN: ps2: ps2_standard_mouse_disconnect input/mouse/ps2/standard_0
KERN: ps2: devfs_unpublish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: Mouse device exiting, General system error
USER 'KS': Notify of added/removed/started/stopped device

This is the complete output of cat /var/log/syslog | grep ps2:

KERN: ps2: probe_mouse Standard PS/2 mouse found
KERN: ps2: devfs_publish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: ps2: devfs_publish_device input/keyboard/at/0, status = 0x00000000
KERN: ps2: keyboard found
KERN: ps2: hot removal of input/mouse/ps2/standard_0
KERN: ps2: ps2_standard_mouse_disconnect input/mouse/ps2/standard_0
KERN: ps2: devfs_unpublish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: ps2_hid: init_hardware
KERN: ps2_hid: init_driver
KERN: ps2: active multiplexing v1.1 enabled
KERN: ps2: active multiplexing not working, not enabling it
KERN: ps2_hid: publish_devices
KERN: ps2_hid: uninit_driver
KERN: loaded driver /boot/system/add-ons/kernel/drivers/dev/input/ps2_hid
KERN: ps2: probe_mouse Standard PS/2 mouse found
KERN: ps2: devfs_publish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: ps2: devfs_publish_device input/keyboard/at/0, status = 0x00000000
KERN: ps2: keyboard found
KERN: ps2: hot removal of input/mouse/ps2/standard_0
KERN: ps2: ps2_standard_mouse_disconnect input/mouse/ps2/standard_0
KERN: ps2: devfs_unpublish_device input/mouse/ps2/standard_0, status = 0x00000000

On another try, my keyboard went as well…

EDITED to add: This is not on a ThinkPad, but a Schenker notebook.

2 Likes

Hello,
Thanks for the feedback. I have now updated the change with a different approach, which should cause less problems. It would be great if some more people could test this one before I break everyones keyboard or touchpad :slight_smile:
Thanks!

That latest patch works for me. So disappearing mouse/keyboard, no syslog entries. :+1:

Two and a half years later…

I have a Toshiba Portege Z30, which has both a trackpoint and a touchpad (and a touchscreen, which surprinsingly works!). None of them works, and they’re not recognized by listdev or Devices.

Syslog endlessly repeats the following lines:

KERN: ps2: hot plugin of input/mouse/ps2/0
KERN: ps2: device input/mouse/ps2/0 still active, republishing...
KERN: ps2: devfs_unpublish_device input/mouse/ps2/0, status = 0x80006003
KERN: ps2_dev: reset failed: I/O error
KERN: ps2: devfs_publish_device input/mouse/ps2/0, status = 0xffffffff

My mind plays tricks on me, as my relationship with Haiku is on and off, but I’m pretty sure both the touchpad and the trackpoint were working sometime around 2022. I guess I could download an old image and try…

1 Like

They are indeed working in R1/Beta 3, so this is a regression. I just filed a bug report: #19266 (Regression: touchpad and trackpoint not working (probably after July 2022)) – Haiku

1 Like

I didn’t notice this thread because I had not got a Thinkpad T480s, yet.
I wonder if the issue here may have to do with this very thread.
The symptom looks similar: the Elantech driver is republished repeatedly and both the trackpad and the trackpoint do not work.
The keyboard does, however.

1 Like

Update: reverting https://cgit.haiku-os.org/haiku/commit/?id=8a00ea4af6786937c1942241b9b0a03fb5d05a1e brings back to life both the touchpad and the trackpoint for me. It is just one line so worth trying. As mentioned in the bug report, I’m guessing the timeout introduced is too little.