Testing wanted - PS2 active multiplexing (Thinkpad trackpoint mainly)

Feedback Hardware
1

Hello,

I made a change to fix a bug with the keyboard controller on my machine: https://review.haiku-os.org/c/haiku/+/5388

I would like to check if that does not break the PS2 active multiplexing support. In particular, this can be checked with Thinkpads which have both a trackpoint and a touchpad. But possibly other laptops will be interesting as well.

To test:

  • Install the image from this change
  • Verify that trackpoint and/or touchpad work as wanted
  • Verify that both input devices (touchpad and trackpoint) are visible in Input preferences if they already were without this change
  • grep ps2 /var/log/syslog to see if there is anything strange there

If some people can confirm that this works as intended on thinkpads, I can merge this change. I don’t want to break your pointing devices and I’m not sure what I did will work correctly.

Thanks for your help!

3 Likes
2

I’ve built the ps2 busmanager with your linked patch and put it into /system/non-packaged/add-ons/kernel/bus_managers. Rebooted and everything seemed fine. Until I touched my touchpad. The PS2 mouse in the Input preferences disappeared with this entry in the syslog:

KERN: ps2: hot removal of input/mouse/ps2/standard_0
KERN: ps2: ps2_standard_mouse_disconnect input/mouse/ps2/standard_0
KERN: ps2: devfs_unpublish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: Mouse device exiting, General system error
USER 'KS': Notify of added/removed/started/stopped device

This is the complete output of cat /var/log/syslog | grep ps2:

KERN: ps2: probe_mouse Standard PS/2 mouse found
KERN: ps2: devfs_publish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: ps2: devfs_publish_device input/keyboard/at/0, status = 0x00000000
KERN: ps2: keyboard found
KERN: ps2: hot removal of input/mouse/ps2/standard_0
KERN: ps2: ps2_standard_mouse_disconnect input/mouse/ps2/standard_0
KERN: ps2: devfs_unpublish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: ps2_hid: init_hardware
KERN: ps2_hid: init_driver
KERN: ps2: active multiplexing v1.1 enabled
KERN: ps2: active multiplexing not working, not enabling it
KERN: ps2_hid: publish_devices
KERN: ps2_hid: uninit_driver
KERN: loaded driver /boot/system/add-ons/kernel/drivers/dev/input/ps2_hid
KERN: ps2: probe_mouse Standard PS/2 mouse found
KERN: ps2: devfs_publish_device input/mouse/ps2/standard_0, status = 0x00000000
KERN: ps2: devfs_publish_device input/keyboard/at/0, status = 0x00000000
KERN: ps2: keyboard found
KERN: ps2: hot removal of input/mouse/ps2/standard_0
KERN: ps2: ps2_standard_mouse_disconnect input/mouse/ps2/standard_0
KERN: ps2: devfs_unpublish_device input/mouse/ps2/standard_0, status = 0x00000000

On another try, my keyboard went as well…

EDITED to add: This is not on a ThinkPad, but a Schenker notebook.

2 Likes
3

Hello,
Thanks for the feedback. I have now updated the change with a different approach, which should cause less problems. It would be great if some more people could test this one before I break everyones keyboard or touchpad :slight_smile:
Thanks!

4

That latest patch works for me. So disappearing mouse/keyboard, no syslog entries. :+1: