[REQUEST] Please, Review and add those patches of fixing of memory leaks - which applicable - to r1beta4 branch

Ahoy Team, @waddlesplash,

Would you be so kind to
review and add patches about fixing memory leaks - which applicable* - to r1beta4 branch ?

*

I was informed earlier from @PulkoMandy that some fixing patches not required for r1beta4 - example was hrev57382 -,
as such fix really neede because iprovements in master caused the errors that must be fixed in such specific patches.
Also you are cautios and careful to rather wait weeks adding such patches to Betas.

I agree both and understand as well, I’ve just seen adding such patches
ended for r1beta4 branch at 2022-12-22 as seen on

List of patches of r1beta4 branch* - filtering ‘leak’

Meanwhile when I filtered list of patches for ‘leak’ on master branch I got more … which among some or more of them may applicable for Beta4 as well.

List of patches of master branch* - filtering ‘leak’

DISCLAIMER :
It’s a request - not a push. Me also accept if I - or we, users - get answer as
no applicable patch for Beta4 – among them.

Thanks in advance,
János

Do you actually notice any memory leaks in beta4? A number of those patches apply to changes done after beta4.

I experience

used up every memory (30-31 GB of 32 GB) if 2 or 3 browsers (Web+ and Falkon , Web runs altogether for a while)
similar like was in case
Fix of X512- to #18724

strange USB ehci (and now xhci due to USB drive change ) errors
(this mostly reduced now only one or to lines after I switched the install media from 32.0 GB Kingston USB 2.0 USB key to a SANDISK 128.0 GB SDXC card in USB an reader)

→ … and escalating this into more vm page fault errors as I can see in the syslog at app and or Haiku freeze

→ and messages like something tried to execute something on invalid Team !
as a crash happens.

At this time fortunately or unfortunately I do not have such messages.

→ once I had no syslogs at all in the directory -
???

→ also sometimes I have syslog or syslog.old … nothing about but mtrr lines … a ton.
I saw article

about MTRR and this is also memory but cached stuff.

So, okay my machine is from 2012, but the firmware’s Diagnostics does not shows errors with memory or CPU. It is a Dell workstation grade laptop with a 3rd gen i7 Extreme Edition. I just see something about memory is not rounded well yet - as we say in Hungarian.

I just want to try out all possibilities that can help me in it - if such errors come up.

Now I am often avoiding to run those browsers altogether or reduce the parallel time - closing one or even 2 as Web+ runs always { until its rare crash nowadays} ).

Those I need as I separated my net activities by browsers - just as I did on linux distros, Windows … and now on Haiku as well.

It might not help those fixes - as it had not helped on that earlier USB key as Adrien informed some of those USB errors - the read errors - indicated that the drive itself damaged on register/cell level, and could not compensate enough units to avoid read errors. This way i changed to this “USB drive”.
Actually financially I can use these earlier available hardware. This SDXC card is just about 2 years old. I bought to have for Haiku install, but I could not use in the built-in SD reader to boot as my firmware seems does not provide SD reader as a boot device in the list of bootable devices, so I cannot select in the firmware. Nor in EFI neither in Legacy mode. But it worked in this one and only reader of Sandisk I found fortunately in my “collection” that I have since PC hobbyist era and IT past when I could bought such stuff.

You may say - even surely - I mix fashion with season and I suspect reason / solution where there is no such things I combined this altogether in my half (or no) knowledge status - and it is siliness as is.

So I cannot confirm what I experience
does relates to memory leak(s) or not -
but also cannot exclude as a reason in case the out-of-memory situation that I described first.

I’m pretty sure this change, at least, was backported.

The others may or may not make any difference to the problems you are mentioning. Have you tried a nightly, is there any difference?

Yepp, this is the one and only exception that was added to r1beta4 branch.

Well, I have an another SD card , but otherwise I am out of USB reader or other install media actually. I have a working 1.4 GB installer that I would not use it for such stuff.
Later I would try to install onto that card, if the built-in SD card and Haiku enables such huge SD card to install at all. And I have somewhere another I think USB 3.0 classic card reader unit that can handle more kind of cards. At least that should handle SDXC, if buit-in does not.
I install the Beta 4 and switch it to nightly.
It would happen in the weekend, so I report back later…
and if I have a luck (or unluck) I provide syslog part with examples of above mentioned errors on R1B4 as well.

This install from prev. weekend still hold - much, much better. Only one classic Haiku freeze, that happened when I did the first refresh-update-full-sync combo of mine. Only force reboot worked. If I had not used after it happened,
yepp now I remember, I got a KDL with same something executed on invalid Team.
Unfortunately I do not have smartphone actually, so I could not take a photo about it. Once I could steal the moment just before the freeze and KDL - look at distorted Deskbar.

This happened on the crappy Kingston, but as you can see I could even get this pic from it now, but packages and or its config files unreliable on HW level, it seems.
The similar happened with actual one, bit it just happens when update from hrev+59 to hrev+96 and all the other packages I have on it.

And one out-of-memory. Solved by killing Web and stopping Falkon.
Since then - peace - until now.

~> grep -E -i error /boot/system/var/log/syslog.old | grep -E -v -i deferred
2024-04-12 02:04:09 KERN: usb error ehci 1: qtd (0xdb9900) error: 0x00088d46
2024-04-12 02:12:20 KERN: usb error ehci 1: qtd (0xd5e900) error: 0x00088d46
2024-04-12 02:12:20 KERN: usb error ehci 1: qtd (0x967000) error: 0x00088d46
2024-04-12 17:20:36 KERN: PCI:   Extended capabilities: Advanced Error Reporting, Serial Number
2024-04-12 17:20:36 KERN: PCI:   Extended capabilities: Virtual Channel, Advanced Error Reporting
2024-04-12 17:20:36 KERN: PCI:   Extended capabilities: Virtual Channel, Advanced Error Reporting
~> 
~> 
~> 
~> grep -E -i error /boot/system/var/log/syslog | grep -E -v -i deferred
2024-04-12 17:20:36 KERN: PCI:   Extended capabilities: Advanced Error Reporting, Serial Number
2024-04-12 17:20:36 KERN: PCI:   Extended capabilities: Virtual Channel, Advanced Error Reporting
2024-04-12 17:20:36 KERN: PCI:   Extended capabilities: Virtual Channel, Advanced Error Reporting
2024-04-12 17:20:36 KERN: ahci: sata_request::finish ATA command 0xa0 failed: status 0x51, error 0x20
2024-04-12 17:20:36 KERN: ahci: sata_request::finish ATA command 0xa0 failed: status 0x51, error 0x20
2024-04-12 17:20:36 KERN: usb_disk: got device name "SanDisk SDDR-113 9412": No error
2024-04-12 17:20:36 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:20:36 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:20:36 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:20:36 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:20:36 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:20:36 KERN: KDiskDeviceManager::InitialDeviceScan() returned error: Bad data
2024-04-12 17:20:36 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:20:39 AUTH 'sshd'[817]: error: setsockopt IPV6_V6ONLY: Operation not supported
2024-04-12 17:20:39 AUTH 'sshd'[817]: error: Couldn't create pid file "/packages/openssh-9.7p1-1/.self/var/run/sshd.pid": No such file or directory
2024-04-12 17:20:46 KERN: package_daemon: [24542305:   732] 2024-04-12 17:20:46 KERN: active package: "libgpg_error-1.47-2-x86_64.hpkg"
2024-04-12 17:20:50 DAEMON 'DHCP': /dev/net/ipro1000/0: DHCP status = No error
2024-04-12 17:20:51 KERN: intel_extreme: compute_dpll_g4x: best MHz: 140 (error: 0)
2024-04-12 17:20:53 DAEMON 'DHCP': /dev/net/iprowifi4965/0: DHCP status = No error
2024-04-12 17:20:54 USER: Error in AllUnarchived method of object of type 5BView
2024-04-12 17:20:54 USER: An error occured during unarchival, cleaning up.
2024-04-12 17:34:41 KERN: usb_disk: got device name "Sony Storage Media 1.00": No error
2024-04-12 17:34:41 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:34:41 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:52:31 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 17:53:35 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 22:35:05 KERN: usb_disk: got device name "Kingston DT Micro PMAP": No error
2024-04-12 22:35:07 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 22:35:07 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 22:35:07 KERN: ntfs: error: identify_partition: boot signature doesn't match
2024-04-12 22:35:07 KERN: ntfs: error: identify_partition: boot signature doesn't match
~>