I ported tuxpuck :)

Luca91 · August 10, 2023, 6:42pm

Hi,
I wanted to try porting some software not written by me, so today I tried porting tuxpuck and succeeded
This is an old school opensource game that I used to play during my teenager years. I was able to build it from source by just adding a #define (don’t worry, it can be wrapped in an #ifndef).

Some screenshots:

Now I’m going to read up on how to build the recipe and send it to the haiku repository

Luca91 · August 10, 2023, 9:54pm

I’m going to use this thread to ask some hints for the recipe.
In BUILD_REQUIRES I’ve specified
“devel:freetype$secondaryArchSuffix” and “devel:libVorbis$secondaryArchSuffix”
but it says that these dependencies could not be resolved.
I doublechecked and they are both presents in haikudepot (freetype_devel and libVorbis_devel).
Any hint please? thanks a lot.

Lrrr · August 11, 2023, 1:30am

The freetype requirement should have a ‘lib’ prefix devel:libfreetype$secondaryArchSuffix

Have you tried to build any other packages using these libraries? Are you using the --get-dependencies option to haikuporter? Are you building on 32 bit or 64 bit? It might help to see the full recipe you are working on.

Begasus · August 11, 2023, 5:31am

If I encounter a wrong dependency in a recipe I mostly open the mentioned package with Expander, in there it will list the PROVIDES for lib:* and devel:* (packages), this way you are sure there are no typos made.
Good luck, looking forward on testing it, remember it from long ago

PulkoMandy · August 11, 2023, 7:17am

And the libvorbis one should be all lowercase: devel:libvorbis$secondaryArchSuffix

Luca91 · August 11, 2023, 9:37am

@Lrrr @Begasus @PulkoMandy thank you everyone. I wan’t using --get-depencencies, so this was the issue (plus the ‘lib’ prefix).
Now I’m having a compilation issue while building from haikuporter, it can’t find ft2build.h. I noticed that hakuporter installs freetype_bootstrap instead of freetype_devel, maybe is this the issue?

When this issue will be fixed, I think that I’m ready to send a PR.
Thanks

Begasus · August 11, 2023, 10:55am

It probably uses the old detection for freetype, some patches are around at haikuports, one of them being:

github.com

haikuports/haikuports/blob/ac30a317f58da1385ed5c3e58aa15c9fda8c8792/dev-lang/tk/patches/tk-8.6.10.patchset#L195


      
               /*
                * We need the SDL event handling run in the main thread,
                * which seems to be a Cocoa requirement. Therefore Tk_MainEx()
          -- 
          2.36.1
          
          

          
From e52458cf0424ef1318143c41cc816101ff6678b7 Mon Sep 17 00:00:00 2001
          From: begasus <begasus@gmail.com>
          Date: Thu, 12 May 2022 14:20:59 +0200
          Subject: tk fails to find freetype's header ft2build.h
          
          
Haikuports version for freetype doesn't provide freetype-config
          Change order to check with pkg-config prior to check with freetype-config
          
          
diff --git a/sdl/configure b/sdl/configure
          old mode 100755
          new mode 100644
          index 691c0cd..889c7f0
          --- a/sdl/configure
          +++ b/sdl/configure

Luca91 · August 11, 2023, 11:25am

@Begasus sorry for all my noob questions. I tried to build from source again and it compiles fine. So I get that ft2build.h error only when building from haikuporter. Also, I wasn’t able to find any reference to freetype-config in the makefile. Any other idea? Thanks a lot.

EDIT: After closer look at the terminal, I see “pkg-config command not found”, uhm…

PulkoMandy · August 11, 2023, 11:30am

So you can add that to your BUILD_PREREQUIRES and it will be found then

Luca91 · August 11, 2023, 3:27pm

Thank you, it was “cmd:pkg_config” (the dash in pkg-config is replaced by ‘_’).

Luca91 · August 11, 2023, 7:04pm

PR is now live: Tuxpuck: add recipe by Luca1991 · Pull Request #9184 · haikuports/haikuports · GitHub

Begasus · August 12, 2023, 9:03am

Review done, left some comments there, at least some changes are required, other then that, nice work!

Luca91 · August 12, 2023, 2:35pm

Thanks @Begasus I applied the proposed fixes and updated the PR.
I wasn’t able to reproduce the reported high cpu/ram usage bug tho, I have attached some screenshots in the PR.