The documentation you’ve read must be outdated.
Registering accounts on the review site should work and doesn’t require Github.
It’s https://www.haiku-os.org/guides/building/get-source-git/.
The text is:
Setup an account on Gerrit
Log in to Gerrit code review. For the time being, using a GitHub account is necessary.
If that’s outdated, I guess I should be figuring out who to email about the error I get on login.
Thanks.
What error message do you get?
Login works fine for me,and I don’t even have an M$ Github account.
I get a 403-forbidden message after entering my password.
I checked from DuckDuckGo on MacOS, and it behaves the same there.
I also checked from the browser console (on a fresh session), and it looks like review.haiku-os.org is giving me 403s when I’m not logged in on some background calls to:
https://review.haiku-os.org/accounts/self/detail
https://review.haiku-os.org/auth-check
I checked my pi-hole and it’s hasn’t filtered any requests from my Haiku laptop yet today, so it’s not that.
Maybe too strict firewall rules against scraper bots on the server?
@kallisti5 should have a look at that.
I can provide my source IP to anyone who’s looking through logs on this; it’ll be the same as my source IP for accessing this forum.
We use a SSO for gerrit now, iirc you can login to it with github but not to gerrit directly anymore
That seems expected, this is what Gerrit does when you try to access a page that needs login.
But it shouldn’t do so after you log in.
With firewall rules you would not get a 403, you would get no reply at all.
To be systematic about it, on a fresh browser session:
- go to review.haiku-os.org
- click “sign in”, get asked for username
- give username, get asked for password
- on submitting the password I get a 404
- the URL on that page is (with codes removed):
https://review.haiku-os.org/oauth?state=[...]&iss=https%3A%2F%2Fsso.haiku-os.org%2Frealms%2Fhaiku&code=[...]
- if I go back to review.haiku-os.org from there I’m not signed in
- if I click “sign in” at that point I get a 403
So the problem seems to start with sso’s redirect to review landing on a 404?