My progress at porting Ladybird, the SerenityOS Browser

nipos · June 15, 2024, 5:19pm

They could have really communicated that more clearly in the Readme.
I thought that both projects accept contributions,but go into slightly different directions.
Well,I’m now cloning the other Ladybird repo and will try if that one also works with my patches or if additional work is required.
Maybe you can still try to send the patches to SerenityOS,I guess it’s worth a try at least?

cb88 · June 15, 2024, 6:08pm

Frankly that remains to be seen I think the whole situation is kind of half hatched to begin with…

win8linux · June 15, 2024, 6:17pm

Just had a bit of a talk with SerenityOS contributors, they said that they won’t accept Haiku support patches but recommended sending them to the Ladybird folks instead.

nipos · June 15, 2024, 6:23pm

I’m already starting to love the new Ladybird
Even on FreeBSD it does now throw errors,but that was fairly simple,only changing two MacOS ifdefs to catch all BSDs.
Then,on OpenIndiana,I’m stuck with one of the new dependencies not being in the repository at all,so I guess I’ll do that one at the end.
On Haiku the dependencies are there,but so are tons of new errors.
Firstly the same one as on FreeBSD,also easy to fix here,but now I’m blown away by a big wall of errors on different places,partially related to ICU.
Hell,why do they think it’s a good idea to require ICU and other stuff now?
It’s only two weeks of being independent from Serenity and so many major changes already.
We’ll see if I manage to make that all work.

Edit: @win8linux are you also interested in sending patches for other OSes to upstream or only Haiku?
FreeBSD is already done here on my computer and keeping it private would somehow be a waste of time for me.

win8linux · June 15, 2024, 6:40pm

I’m fine with sending patches for other OSes, if you have them.

nephele · June 25, 2024, 6:41pm

27 posts were split to a new topic: ICU in Haiku

KitsunePrefecture · June 16, 2024, 2:32pm

As a Haiku user - and web browser gatherer - I take it interestingly as a good news that Ladybird development has a recap …

but

when we can put hands on ?
can we upgrade it on Beta4 ?

( I play over the hurrily expectations ! ;-)) )

san2ban · June 16, 2024, 2:36pm

These changes that you have mentioned, will it be updated in the Haikudepot? If I download Ladybird from Haikudepot, will it havethese changes that you have mentioned above?
Last time I tried Ladybird, it used to crash at random, hang up

nipos · June 16, 2024, 2:42pm

It is unlikely that the new Ladybird update will appear in the Depot anytime soon,since it requires functions that,I think,are only available in the Nightly version currently,such as arc4random_buf()
You can,however,clone the Ladybird git repo and compile it yourself after my changes are merged.
Beware that Ladybird is still alpha software and will still crash from time to time,but the websites render a lot more correct now compared to the outdated version in the HaikuDepot,so it’s still worth the effort.

I have yet already managed to completely compile and run the new Ladybird from the forked repo.
I only need to do some cleanup,put my changes into commits and then you can give it a try.
Expect 2 or 3 hours,something like that.

KitsunePrefecture · June 16, 2024, 3:00pm

Thanks for your efforts and reply

nipos · June 16, 2024, 4:53pm

Begasus · June 21, 2024, 12:01pm

Aside from all this ICU talk, how is the process progressing?

win8linux · June 21, 2024, 3:20pm

Not much yet, since I’ve been busy for the last week and recently gotten rather sick. So, I haven’t been able to check the patches from @nipos yet unfortunately. Body willing, maybe I’ll be able to review patches for submission to upstream in a couple days.

Begasus · June 21, 2024, 3:21pm

Thanks on the notice! Hope you feel well soon, take your time, no pressure

nipos · June 21, 2024, 4:47pm

Let me know if everything works as it should or if patches need to be adjusted to new changes from upstream

KitsunePrefecture · June 21, 2024, 9:53pm

Ahoy @win8linux ,

Thanks for the update
Have a rest to be well !

X512 · June 25, 2024, 6:44pm

Why not concatenate all patches into one like it is done in HaikuPorts?

nipos · June 25, 2024, 7:05pm

Git automatically creates multiple files when running git format-patch.
I guess they could be merged into one file while still keeping it separated into commits,but I didn’t bother to try.

I’m very sorry for going off-topic again,now that the ICU stuff was finally split into it’s own topic,but regarding the HaikuPorts patchset stuff…
I find it overly complicated to work with it,doing minimal changes and porting it to the next version.
I also regularly contribute to the OpenIndiana package repository and there we have a patches folder for each package and you can put patches for different things in different files which are smaller and easier to maintain.
Patches are generated using GNU diff and applied using GNU patch.
See here for an example: oi-userland/components/web/librewolf at oi/hipster · OpenIndiana/oi-userland · GitHub
(Just to showcase that as example,I don’t want to start a war over the best patch format here)

X512 · June 25, 2024, 7:59pm

You can use git format-patch --stdout > patchset.diff to produce single patchset file. It still preserve individual commits.

dcatt · July 5, 2024, 3:54pm