GSOC 2021:Progress Report of Improvements to clang-format | Haiku Project

[owenca]

@PulkoMandy

I missed the fact that you had made changes to llvm upstream, that was not mentionned anywhere until very recently in this thread. How could I have guessed? So from my point of view it was just some changes disapearing from your patch in the github repo without any explanation.

You didn’t have to guess as I did mention it in this email last year.

@PulkoMandy

Your only reply was “I will look into this sometime next week” then nothing for almost a month

Like I said, it turned out that I didn’t have enough time to sort it all out at the time.

@PulkoMandy

Then there is a comment from me saying that I further rebased the changes on llvm 11. This is before you did any other work, unless you had some things in llvm upstream at the time, but that, I had no way to know.

I just reviewed our comments on that PR, and the following transpired:
Because you mentioned that you merged your repo with LLVM 11, I did try to target LLVM 11 as well when updating haiku-format 6. As LLVM 11 could not be built on Haiku then, I had no choice but to target LLVM 10 instead.

@PulkoMandy

So I was quite confused by this, the patch from korli being merged but my version based on llvm 11 being ignored, and then the changes being undone to put in an apparently almost empty patch in its place.

I didn’t know you wanted your merge of haiku-format 6 with LLVM 11 to be somehow included because you didn’t create a PR. As explained above, I could not target LLVM 11 even if I wanted to. In the end, I couldn’t really use korli’s merge of haiku-format 6 with LLVM 9 either.

@PulkoMandy

But you did not tell me anything about what I was missing.

I thought it was obvious that you would fork LLVM 10.0.1 and apply the diff file from haiku-format 10 as you had not added anything of substance to either haiku-format 6 or clang-format 10 or 11 by then. However, your repo remained stale for at least a few months while no more real issues were created on mine either.

@PulkoMandy

Why give the warning and the full explanation only months later? If I had known about it earlier, it would have saved time and frustration for everyone

I didn’t really know what you wanted to do and how you mentored saloni. It appeared to me that you wanted to discard haiku-format 10 and start with a new customized clang-format based on LLVM 11 or the main trunk, perhaps cherry picking haiku-format 10 along the way. Nevertheless, I did give warnings and advice before (see here and here), but they were by and large ignored. Anyway, if you had asked, I would have explained. If I had known what you were up to, I would have warned.

It is what it is now, so let’s stop blaming each other and move forward. If you want my help, just let me know.