Code style

1

I don’t want to start any wars so I’ll ask this plainly.

Are we going to clean up the code in the tree so that all the apps are coded in the same style?

For example some apps start with:

MyApp app;
app.Run();
return 0;

while others are:

MyApp();
be_app->Run();
delete be_app;
return 0;

and probably a half dozen other variations.

I just want to know what standards we are coding by. Shouldn’t the bundled apps all be using the same style? If i’m off base just let me know.

2

the usual comment is to use the opentracker guidelines:
http://www.opentracker.be/guidelines.html

If it’s not located in that document somewhere, then we probably need to address it (I’ve never read the whole thing).

3
inseculous wrote:

Are we going to clean up the code in the tree so that all the apps are coded in the same style?

For example some apps start with:

MyApp app;
app.Run();
return 0;

while others are:

MyApp();
be_app->Run();
delete be_app;
return 0;

and probably a half dozen other variations.

I just want to know what standards we are coding by. Shouldn’t the bundled apps all be using the same style? If i’m off base just let me know.

These variations are valid source codes. Personaly i don’t care, provided it works and it follows our code guidelines as Kurtis mentioned. IMO, consistency is only important in our API, or naming scheme.

4

I’ve read the tracker guide before and it is targetted more toward the source code formatting not the content. It would be nice to see a wiki update to this to cover more topics like constant naming, class naming, message values and the like. I was just thinking that since most people will be using the bundled apps as guides for coding on the system that there should be some common style through out them. Right now it’s kinda an anything goes hodge podge.